fix(doctrine): PartialSearchFilter on multibyte characters #7688
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VincentLanglet
commented
Jan 22, 2026
VincentLanglet
commented
| Q | A |
|---|---|
| Branch? | 4.2 |
| Tickets | Closes #..., closes #... |
| License | MIT |
| Doc PR | api-platform/docs#... |
VincentLanglet
commented
Jan 22, 2026
| $queryBuilder->setParameter($parameterName, $this->formatLikeValue($values)); | ||
|
|
||
| $likeExpression = 'LOWER('.$field.') LIKE :'.$parameterName.' ESCAPE \'\\\''; | ||
| $likeExpression = 'LOWER('.$field.') LIKE LOWER(:'.$parameterName.') ESCAPE \'\\\''; |
Contributor
Author
There was a problem hiding this comment.
There is two way to fix this
- Using
mb_strtolowerin setParameter - Using
Lower(foo) LIKE Lower(bar)
I feel like mixing lower in php and sql is weird (and the origin of error) while using both lower funciton in SQL ensure consistency.
NB: the bug doesnt occur on searchFilter since wrapCase was called on both expression
core/src/Doctrine/Orm/Filter/SearchFilter.php
Lines 316 to 317 in 149fe24
Contributor
Author
|
PHPStan failure is unrelated ; I would prefer fixing it in another PR. |
VincentLanglet
changed the title
VincentLanglet
changed the title
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.