test(symfony): ensure pagination_maximum_items_per_page defaults correctly when config defaults key is absent
#7609
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxcastel
force-pushed
the
test-config-missing-defaults-key
branch
from
b6e6f6d to
fb75479
Compare
…ectly when config defaults key is absent
Maxcastel
force-pushed
the
test-config-missing-defaults-key
branch
from
fb75479 to
71b57d2
Compare
Maxcastel
changed the title
pagination_maximum_items_per_page defaults correctly when config defaults key is absent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test to the
ApiPlatformExtensionTestto ensure that thepagination_maximum_items_per_pageparameter is correctly set to its default value when thedefaultsconfiguration key is absent from the configuration.Commit 2aa0eb1 introduced an array access safeguard (
$config['defaults'] ?? []) inApiPlatformExtension.phpto prevent theWarning: Undefined array key "defaults"error reported in PR #7567 when attempting to read the configuration optionpagination_maximum_items_per_page.The error was fixed, but no test was added to verify the non-regression (if someone removes the array safeguard (
?? []), the tests still pass).This test unsets the
defaultskey from the configuration array before loading the extension, ensuring that the fallback mechanism works as expected and that the default value forpagination_maximum_items_per_page(30) is correctly applied.