-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viz trajectories #41
Viz trajectories #41
Conversation
Hi @JCharline !
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JCharline, thanks for the PR! Here is the first round of reviews.
Please format your code using pre-commit like @Thomzoy mentioned to pass the tests.
Co-authored-by: Vincent M <[email protected]>
Co-authored-by: Vincent M <[email protected]>
Co-authored-by: Vincent M <[email protected]>
…cikit into viz_trajectories
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage ? 83.80%
=======================================
Files ? 82
Lines ? 2488
Branches ? 0
=======================================
Hits ? 2085
Misses ? 403
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JCharline, here is probably the last review before merging :)
Co-authored-by: Vincent M <[email protected]>
Co-authored-by: Vincent M <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @JCharline, LGTM :)
Thanks @Vincent-Maladiere for the review ! Happy to merge 🥳 |
Very nice PR, thanks @JCharline for the feature and @Vincent-Maladiere for the review ;) |
Co-authored-by: Vincent M <[email protected]>
Co-authored-by: Vincent M <[email protected]>
Co-authored-by: Vincent M <[email protected]>
Thanks @Thomzoy, it should be okay by now ! |
Patient trajectories vizualisation
Description
PR addressing issue #30.
Function to plot individual event sequences. Events can be one-time/continuous, categorized in event families or relative from an index date.
Vizualisation parameters are also accepted, such as event colors, labels, and figure parameters.
Checklist