Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz trajectories #41

Merged
merged 43 commits into from
Apr 20, 2023
Merged

Viz trajectories #41

merged 43 commits into from
Apr 20, 2023

Conversation

JCharline
Copy link
Contributor

Patient trajectories vizualisation

Description

PR addressing issue #30.

Function to plot individual event sequences. Events can be one-time/continuous, categorized in event families or relative from an index date.

Vizualisation parameters are also accepted, such as event colors, labels, and figure parameters.

Checklist

  • If this PR is a bug fix, the bug is documented in the test suite.
  • Changes were documented in the changelog (pending section).
  • If necessary, changes were made to the documentation (eg new pipeline).

@JCharline JCharline marked this pull request as draft March 28, 2023 12:24
@Thomzoy
Copy link
Collaborator

Thomzoy commented Mar 30, 2023

Hi @JCharline !
Thanks a lot for this PR, it looks great !
Could you maybe rebase and run pre-commit so that the CI is passing ?

pre-commit install
pre-commit run --all-files

Copy link
Collaborator

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JCharline, thanks for the PR! Here is the first round of reviews.
Please format your code using pre-commit like @Thomzoy mentioned to pass the tests.

eds_scikit/plot/event_sequences.py Outdated Show resolved Hide resolved
eds_scikit/plot/event_sequences.py Show resolved Hide resolved
eds_scikit/plot/event_sequences.py Show resolved Hide resolved
eds_scikit/plot/event_sequences.py Outdated Show resolved Hide resolved
eds_scikit/plot/event_sequences.py Outdated Show resolved Hide resolved
eds_scikit/plot/event_sequences.py Outdated Show resolved Hide resolved
eds_scikit/plot/event_sequences.py Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
@Vincent-Maladiere Vincent-Maladiere marked this pull request as ready for review April 4, 2023 13:02
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@2e4c960). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage        ?   83.80%           
=======================================
  Files           ?       82           
  Lines           ?     2488           
  Branches        ?        0           
=======================================
  Hits            ?     2085           
  Misses          ?      403           
  Partials        ?        0           
Impacted Files Coverage Δ
eds_scikit/datasets/__init__.py 81.48% <100.00%> (ø)
eds_scikit/datasets/synthetic/event_sequences.py 100.00% <100.00%> (ø)
eds_scikit/plot/event_sequences.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JCharline, here is probably the last review before merging :)

eds_scikit/plot/event_sequences.py Outdated Show resolved Hide resolved
eds_scikit/plot/event_sequences.py Outdated Show resolved Hide resolved
eds_scikit/plot/event_sequences.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @JCharline, LGTM :)

@JCharline
Copy link
Contributor Author

Thanks @Vincent-Maladiere for the review ! Happy to merge 🥳

@Thomzoy
Copy link
Collaborator

Thomzoy commented Apr 17, 2023

Very nice PR, thanks @JCharline for the feature and @Vincent-Maladiere for the review ;)
One last thing, could you rebase main and add your contribution to the changelog ?

@JCharline
Copy link
Contributor Author

Thanks @Thomzoy, it should be okay by now !

@Thomzoy Thomzoy merged commit 07da440 into aphp:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants