[WIP] plot_age_pyramid: add the possibility to have one datetime_ref that differs for each patient #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iffers for each patient: eg. the date of their inclusion in the study.
strayMat
changed the title
Vincent-Maladiere
suggested changes
Dec 8, 2022
There was a problem hiding this comment.
Hey, @strayMat thank you for this PR! Below are some comments before merging.
- add a new test for pytest.raise - add a parsable datetime string - add better error messages when bad value or bad type
Thomzoy
reviewed
Dec 8, 2022
Co-authored-by: Thomas Petit-Jean <[email protected]>
|
Looks good! We need to merge #20 before we merge this PR as well. |
Codecov ReportBase: 95.08% // Head: 94.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 95.08% 94.94% -0.14%
==========================================
Files 65 65
Lines 2034 2057 +23
==========================================
+ Hits 1934 1953 +19
- Misses 100 104 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Where are we for this PR ? I am not sure to see what is missing before merging ? |
3 tasks
|
Close in favor of #43 to avoid nested merging conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous plot_age_pyramid function only allow for one fixed datetime reference for all persons.
In some case studies , we would like to have a different datetime of reference for each person.
Eg. the date of their inclusion in the study. The objective is to draw the pyramid of ages of patient at inclusion. (Very useful and more pertinent when we have cohorts over a long time period).
Description
Add to plot_age_pyramid the possibility to give the datetime_ref argument as a column name.
Checklist