-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.11.0.rc2: Widespread code reorganization (much more separation of concerns) #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 763
💛 - Coveralls |
Writing one of the tests uncovered two bugs \o/ (one an artifact from my last refactoring and one a bug that's been sitting around for who knows how long). |
xavivars
approved these changes
Mar 26, 2018
Merged and released as rc2. Final rc will be rc3 and only planned changes are increased test coverage/test organization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apertium_apy.handlers
. the problem with bunching them up into more than one per file is then they become undiscoverable or file names would become super long/contrived (fixes Refactor apy.py handlers into multiple files #95)apertium_apy
. maybe intotools
?re
parsing with streamparser (will require it for more endpoints) (Replace all re streamparsing with streamparser calls #98)consistent string formatting (linter?)this would take a lot of changes for not that much value