ZOOKEEPER-4898: FastLeaderElection WorkerSender/WorkerReceiver don't need to be Thread #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d leads to the failure of exception handling
kezhuw
reviewed
Feb 28, 2025
There was a problem hiding this comment.
I am not sure why ZOOKEEPER-1810 introduced separated thread. But there are do differences in behavior in logging(jdk System.err vs slf4j LOG.info).
I am good to the direction. Also, it will supersede ZOOKEEPER-4884.
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java
Show resolved
Hide resolved
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java
Show resolved
Hide resolved
…d leads to the failure of exception handling
kezhuw
approved these changes
Feb 28, 2025
tisonkun
approved these changes
Feb 28, 2025
tisonkun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkerSender inherits from ZooKeeperThread. When using WorkerSender, a WorkerSender thread is created first, followed by the creation of a new thread where WorkerSender is passed as a task. At this point, the ExceptionHandler in ZooKeeperThread does not take effect.