Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4804 Use daemon threads for Netty client #2142

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Feb 22, 2024

No description provided.

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @stoty !

@stoty
Copy link
Contributor Author

stoty commented Mar 8, 2024

I have re-run the test suite on an empty change, and it fails the same way as these checks.
#2145

So the test failure is pre-existing.

@stoty
Copy link
Contributor Author

stoty commented Mar 8, 2024

The test failure already has a ticket : https://issues.apache.org/jira/browse/ZOOKEEPER-4746

@anmolnar
Copy link
Contributor

anmolnar commented Mar 8, 2024

I don't get it. The same test suite runs fine in hadoop-ci:
https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-2142/3/pipeline

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending to merge ...

Thanks for your contribution @stoty!

@tisonkun tisonkun merged commit 803c485 into apache:master Mar 9, 2024
12 of 13 checks passed
asfgit pushed a commit that referenced this pull request Mar 20, 2024
Co-authored-by: tison <[email protected]>
(cherry picked from commit 803c485)
Signed-off-by: Andor Molnar <[email protected]>
stoty added a commit to stoty/zookeeper that referenced this pull request Mar 20, 2024
Co-authored-by: tison <[email protected]>
Change-Id: I2563af9e68f6ed9fc937e6285f0955087d8a2362
stoty added a commit to stoty/zookeeper that referenced this pull request Mar 20, 2024
AlphaCanisMajoris pushed a commit to AlphaCanisMajoris/zookeeper that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants