-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOOKEEPER-4804 Use daemon threads for Netty client #2142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks @stoty !
I have re-run the test suite on an empty change, and it fails the same way as these checks. So the test failure is pre-existing. |
The test failure already has a ticket : https://issues.apache.org/jira/browse/ZOOKEEPER-4746 |
I don't get it. The same test suite runs fine in hadoop-ci: |
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending to merge ...
Thanks for your contribution @stoty!
Co-authored-by: tison <[email protected]> (cherry picked from commit 803c485) Signed-off-by: Andor Molnar <[email protected]>
Co-authored-by: tison <[email protected]> Change-Id: I2563af9e68f6ed9fc937e6285f0955087d8a2362
Co-authored-by: tison <[email protected]>
Co-authored-by: tison <[email protected]>
No description provided.