ZOOKEEPER-4798: Secure prometheus support #2127
Merged
+313
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Feb 7, 2024
...metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java
Outdated
Show resolved
Hide resolved
purushah
force-pushed
the
ZOOKEEPER-4798
branch
10 times, most recently
from
a97f778 to
47e9896
Compare
|
Hello @eolivelli, I have taken your suggestions into consideration and made the necessary changes. Can you please review the patch and let me know your thoughts? |
eolivelli
requested changes
Mar 16, 2024
...metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java
Outdated
Show resolved
Hide resolved
purushah
force-pushed
the
ZOOKEEPER-4798
branch
2 times, most recently
from
f0f85b5 to
ee85c25
Compare
|
@eolivelli, could you please merge it? I am worried that further delay could lead to conflicts. |
hezhangjian
approved these changes
Aug 2, 2024
tisonkun
approved these changes
Aug 2, 2024
|
Thanks for your contribution! LGTM. I'll wait a bit for CI and then merge if no blocker. |
|
cppunit failure should be unrelated to this patch. Merging ... |
|
@tisonkun @eolivelli branch-3.9 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.