ZOOKEEPER-2590 exists() should check read ACL permission #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I retriggered the tests, but it seems to me that we need to fix some C++ tests. @ztzg Would you please give a hand here? |
|
@eolivelli I need to make a tiny change on the patch, because we shouldn't throw exception if the znode doesn't exist in exists(). We should skip ACL check in this case and return proper |
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Dec 4, 2023
ZOOKEEPER-2590:exists() should check read ACL permission ZOOKEEPER-2590. Skip ACL check if znode is missing Reviewers: eolivelli Author: anmolnar Closes #2093 from anmolnar/ZOOKEEPER-2590 (cherry picked from commit ceebda9) Signed-off-by: Andor Molnar <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 4, 2023
ZOOKEEPER-2590:exists() should check read ACL permission ZOOKEEPER-2590. Skip ACL check if znode is missing Reviewers: eolivelli Author: anmolnar Closes #2093 from anmolnar/ZOOKEEPER-2590 (cherry picked from commit ceebda9) Signed-off-by: Andor Molnar <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 4, 2023
ZOOKEEPER-2590:exists() should check read ACL permission ZOOKEEPER-2590. Skip ACL check if znode is missing Reviewers: eolivelli Author: anmolnar Closes #2093 from anmolnar/ZOOKEEPER-2590 (cherry picked from commit ceebda9) Signed-off-by: Andor Molnar <[email protected]>
AlphaCanisMajoris
pushed a commit
to AlphaCanisMajoris/zookeeper
that referenced
this pull request
Mar 28, 2024
ZOOKEEPER-2590:exists() should check read ACL permission ZOOKEEPER-2590. Skip ACL check if znode is missing Reviewers: eolivelli Author: anmolnar Closes apache#2093 from anmolnar/ZOOKEEPER-2590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.