Removing heap memory allocation for cert.ca using strdup() since strt…

…ok() doesn't always return a pointer to the heap allocated memory.
apache · Nov 28, 2024 · 441ec15 · 441ec15
1 parent 264cec2
commit 441ec15
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/zookeeper-client/zookeeper-client-c/src/zookeeper.c b/zookeeper-client/zookeeper-client-c/src/zookeeper.c
@@ -692,7 +692,6 @@ static void destroy(zhandle_t *zh)
 #ifdef HAVE_OPENSSL_H
     if (zh->fd->cert) {
         free(zh->fd->cert->certstr);
-        free(zh->fd->cert->ca);
         free(zh->fd->cert);
         zh->fd->cert = NULL;
     }
@@ -1455,7 +1454,7 @@ zhandle_t *zookeeper_init_ssl(const char *host, const char *cert, watcher_fn wat
 {
     zcert_t zcert;
     zcert.certstr = strdup(cert);
-    zcert.ca = strtok(strdup(cert), ",");
+    zcert.ca = strtok(zcert.certstr, ",");
     zcert.cert = strtok(NULL, ",");
     zcert.key = strtok(NULL, ",");
     zcert.passwd = strtok(NULL, ",");