[XMLBEANS-617] Support recursing directories (sourceDir configuration parameter) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
reviewed
Dec 21, 2023
| @@ -15,6 +15,13 @@ | |||
|
|
|||
| package org.apache.xmlbeans.impl.tool; | |||
|
|
|||
| import org.apache.commons.io.FileUtils; | |||
There was a problem hiding this comment.
we don't yet have a compile/runtime dependency on the commons-io jar
commons-io is only currently used in some tests
The POM and build files will need to be changed
It would probably also require us to rename the next release as 5.3.0 because the extra dependenecy makes this a less trivial upgrade.
|
I added a variant of this. See da1e4a2
Tested with https://github.com/pjfanning/xmlbeans-maven-sample/tree/xmlbeans-617 |
|
Awesome, when is this expected to be released? |
|
There are no plans for a release. Until we do a release, you can build your own copy of the jar. There is a snapshot at https://ci-builds.apache.org/job/POI/job/POI-XMLBeans-DSL-1.8/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config parameter (sourceSubdirs, default false) to allow for checking subdirectories of the sourceDir folder