-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: add safety warning to pickle_memoize cache loading #18925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+34
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import pytest | ||
| import pickle | ||
| import tempfile | ||
| import os | ||
|
|
||
|
|
||
| def test_pickle_memoize_warns_on_cache_load(): | ||
| """Test that loading a cached pickle file emits a UserWarning.""" | ||
| from tvm.contrib.pickle_memoize import memoize | ||
|
|
||
| # Create a cache file | ||
| with tempfile.TemporaryDirectory() as tmpdir: | ||
| cache_path = os.path.join(tmpdir, "test_cache") | ||
|
|
||
| @memoize("test_warning_cache") | ||
| def dummy_func(): | ||
| return 42 | ||
|
|
||
| # First call creates cache | ||
| result = dummy_func() | ||
| assert result == 42 | ||
|
|
||
| # Second call loads from cache — should warn | ||
| with pytest.warns(UserWarning, match="Pickle files can execute arbitrary code"): | ||
| result2 = dummy_func() | ||
| assert result2 == 42 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a user warning, which is great for security awareness. However, there is no test to verify that this warning is actually triggered when loading from a cached pickle file. Please consider adding a test case to
tests/python/contrib/test_memoize.pythat usespytest.warnsto assert that theUserWarningis raised.