[Analyzer] Enhance ConstIntBoundAnalyzer and IntervalSet with modular set analysis #18330
+142
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LeiWang1999
commented
Sep 21, 2025
LeiWang1999
commented
- Added modular set analysis to ConstIntBoundAnalyzer for tighter bounds when min_value equals max_value.
- Introduced ComputeGCD function to calculate the GCD of two integers.
- Updated Combine functions in IntervalSet to accept operation nodes for better type handling.
- Enhanced tests for modular set bounds in both const integer bounds and interval sets.
- Added modular set analysis to ConstIntBoundAnalyzer for tighter bounds when min_value equals max_value. - Introduced ComputeGCD function to calculate the GCD of two integers. - Updated Combine functions in IntervalSet to accept operation nodes for better type handling. - Enhanced tests for modular set bounds in both const integer bounds and interval sets.
tqchen
requested changes
Sep 21, 2025
| if (b.min_value > 0) { | ||
| int64_t b_max_cap = InfAwareAdd(b.max_value, -1); | ||
| // Try to get tighter bounds using modular set information | ||
| if (parent_ && b.min_value == b.max_value) { |
There was a problem hiding this comment.
if we have the bound analysis already in IntervalSet, is the const int bound still necessary? just want to get a sense of if we need to introduce tihs bound
There was a problem hiding this comment.
from my understanding, const int bound is faster to analysis, and IntervalSet can build on those constant bounds for further analysis. keeping them separate makes the design clearer in my view.
|
@LeiWang1999 would be great to followup on the notes and get it in |
|
@tqchen sure, sorry for the delay. I'll work on this tomorrow. |
|
@tvm-bot rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.