[Bugfix] Fix improper touched buffer assignment of Pass MergeSharedMemoryAllocations #17438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #17375, the current rule for assigning touched buffers is not appropriate. Consider the following example:
This setup works by chance in simple GEMM scenarios. However, the correct approach should be
This approach works correctly even in more complex scenarios, such as batched GEMM, where the naive template would fail.
This pull request made a simple modification for
MergeSharedMemory
Pass to enable the right analysis, and always disable the naive naive shared memory buffer fuse if kernel with dynamic inStorageRewrite
Pass