[Relax] Lifted parameters bindings may also be function output #17232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `relax.transform.LiftTransformParams` pass inspected the expression in each `relax::Binding` for variables that were required at runtime, but did not inspect the function's output. As a result, any value that could be computed at compile-time, and was either the function output or used in the function's output tuple, would be undefined in the inference function. This commit updates `LiftTransformParams` to collect variables from both the bound value of `relax::Binding`, and the function's output. While this error only impacted the `shared_transform=False` branch of `LiftTransformParams`, this commit also adds regression tests the `shared_transform=True` use case of `LiftTransformParams`. Closes apache#17231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
relax.transform.LiftTransformParamspass inspected the expression in eachrelax::Bindingfor variables that were required at runtime, but did not inspect the function's output. As a result, any value that could be computed at compile-time, and was either the function output or used in the function's output tuple, would be undefined in the inference function.This commit updates
LiftTransformParamsto collect variables from both the bound value ofrelax::Binding, and the function's output.While this error only impacted the
shared_transform=Falsebranch ofLiftTransformParams, this commit also adds regression tests theshared_transform=Trueuse case ofLiftTransformParams.Closes #17231