-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add copy interface for dataclass #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @guan404ming, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the usability of dataclasses by integrating standard Python copying mechanisms. It provides robust support for creating shallow copies, deep copies, and modified instances, ensuring that dataclasses behave as expected with Python's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for copy.copy(), copy.deepcopy(), and a __replace__ method for FFI dataclasses. This is a valuable addition for creating shallow, deep, and modified copies of dataclass instances. The implementation correctly generates these methods dynamically and integrates them into the c_class decorator. The accompanying tests cover the new functionality well. I've identified a bug in the field classification logic that could lead to redundant assignments during copy operations, and I've provided a suggestion to fix it. Overall, this is a great enhancement.
f5911a0 to
38e3769
Compare
Related Issue
#356
Why
Dataclasses need copy support for creating shallow copies, deep copies, and modified instances.
How
__copy__forcopy.copy()support__deepcopy__forcopy.deepcopy()support__replace__for creating modified copies (Python 3.13+dataclasses.replace()compatible)__init__by calling FFI constructor directly")