[slachiewicz]

Jira: THRIFT-6506

The lib/java Gradle test task only included Test* classes, so seven *Test classes in org.apache.thrift.partial (36 tests) never ran. The include, and Clover's testIncludes, now match *Test too, with matching inner-class excludes; JUnit skips the abstract *TestBase classes. One assertion in ThriftMetadataTest expected a root ==> name toString format the library has never produced, so it is dropped.

Verified: gradle test → 401 executed tests on master, 437 on this branch, 0 failures.

• Did you create an Apache Jira ticket?
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-6506: describe my issue"?
• Did you squash your changes to a single commit?
• Did you do your best to avoid breaking changes? Test configuration only.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Jens-G]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

One suggestion, below the bar for an issue. This PR makes ValidateTest.testCheckPathExists run for the first time. On Windows, its Paths.get("<not-found>") throws InvalidPathException, because < and > are not allowed in a Windows path, and that happens before any assertion runs. No CI job builds lib/java on Windows, so nothing would show it, but lib/java/README.md describes building on a Windows box. A name without reserved characters, for example a child of tempDir that does not exist, would avoid it. This follows from the JDK's Windows path rules; I did not run it on Windows.

thrift/lib/java/src/test/java/org/apache/thrift/partial/ValidateTest.java

Lines 289 to 294 in f2749b5

	@Test
	public void testCheckPathExists() throws IOException {
	Path tempFile = Files.createTempFile("foo", "bar");
	Path tempDir = tempFile.getParent();
	Path notFound = Paths.get("<not-found>");

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.