-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI bump versions of GitHubActions and Ubuntu #2994
base: master
Are you sure you want to change the base?
Conversation
V3 is based on Node.js v16 and will get deprecated. Currently it's just causing a warning. With v4 the artifact-upload action fails as all matrix-jobs use the same name and the default prevents overwriting existing ones. Therefore we use individual artifact names which will also preserve all logs, not just a singe one only.
Ubuntu-20.04 will be EoL in 9 months, therefore let's use the next LTS version as default. Images for ubuntu-24.04 are available, so use them also for building the compiler.
V3 is based on Node.js v16 and will get deprecated. Currently it's just causing a warning. With v4 the artifact-upload action fails as all matrix-jobs use the same name and the default prevents overwriting existing ones. Therefore we use individual artifact names which will also preserve all logs, not just a singe one only. Cherry-picked from PR apache#2994 to avoid incompatibility between v3 and v4 in same workflow.
It will be great to add a dockerFile for Ubuntu 24.04 in folder build/docker, not just in github actions. |
how about just dropping 20.04? |
Ubuntu 20.04 is still active, my opinion is we can remove its support only after EOL. And I suggest you add support for Ubuntu 24.04 instead of removing support for Ubuntu 20.04 |
To keep building compiler with ubuntu -20.04, as long a the image can be uses, and have the compiler build with ubuntu-{20|22|24}.04 in parallel was also my intention. For #2993 (syntax-error in deepcopy() for 0.20.0) I made the code based on this branch. When this code will be accepted, I can rebase it into 2 commits just on top of master, to have a nice linear history. regarding docker images as mentioned by @sveneld: I'm not this deep into docker, that I can setup a test-env quickly. I can for sure copy code from existing images and keep fingers crossed. I there a place where I can see CI-logs that use these docker-images? |
upgrade artifact-actions from v3 to v4
switch to ubuntu-22.04 by default