-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THRIFT-5693 - fix bug in serialization of enum default values #2783
Open
andrewcunnin
wants to merge
1
commit into
apache:master
Choose a base branch
from
andrewcunnin:ac/thrift-5693
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,7 @@ | |
VersioningTestV2, | ||
Xtruct, | ||
Xtruct2, | ||
OptionalEnum, | ||
) | ||
|
||
from Recursive.ttypes import RecTree | ||
|
@@ -193,6 +194,8 @@ def setUp(self): | |
] | ||
) | ||
|
||
self.optional_enum = OptionalEnum() | ||
|
||
def _serialize(self, obj): | ||
trans = TTransport.TMemoryBuffer() | ||
prot = self.protocol_factory.getProtocol(trans) | ||
|
@@ -351,6 +354,12 @@ def testRecVector(self): | |
out_list = self._collapseLinkedList(cur_list) | ||
self.assertEqual(golden_list, out_list) | ||
|
||
def testDefaultEnum(self): | ||
"""Ensure default enum values are serializable""" | ||
obj = self._deserialize(OptionalEnum, self._serialize(self.optional_enum)) | ||
self.assertEquals(obj, self.optional_enum) | ||
|
||
|
||
|
||
class NormalBinaryTest(AbstractTest): | ||
protocol_factory = TBinaryProtocol.TBinaryProtocolFactory() | ||
|
@@ -451,6 +460,8 @@ def _enumerate_enum(enum_class): | |
self.assertEquals(obj, objcopy) | ||
|
||
|
||
|
||
|
||
Comment on lines
+463
to
+464
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here, you are making it 4 blank lines between the class above and |
||
def suite(): | ||
suite = unittest.TestSuite() | ||
loader = unittest.TestLoader() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excessive blank lines. I think the general python style is 2 blank lines between classes/top level stuff and one blank line between functions inside the same class. here you are making it 3 blank lines between classes.