Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4537: Fix several time comparison issues. #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ayushtkn
Copy link
Member

Fix t1 < t2 kind of comparisons

@abstractdog
Copy link
Contributor

#300 (comment)
numerical overflow: does this exactly mean the possible negative values of the arbitrary origin time?

@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 9m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 🆗 mvndep 5m 13s Maven dependency ordering for branch
+1 💚 mvninstall 10m 37s master passed
+1 💚 compile 2m 29s master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 compile 2m 11s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚 checkstyle 2m 7s master passed
+1 💚 javadoc 1m 42s master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 javadoc 1m 31s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+0 🆗 spotbugs 1m 40s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 2s master passed
-0 ⚠️ patch 2m 4s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 1m 38s the patch passed
+1 💚 compile 1m 49s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 javac 1m 49s the patch passed
+1 💚 compile 1m 29s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚 javac 1m 29s the patch passed
+1 💚 checkstyle 1m 3s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 51s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 javadoc 0m 49s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
+1 💚 findbugs 4m 35s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s tez-common in the patch passed.
+1 💚 unit 0m 42s tez-runtime-internals in the patch passed.
+1 💚 unit 5m 27s tez-runtime-library in the patch passed.
+1 💚 unit 5m 9s tez-dag in the patch passed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
67m 20s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-332/2/artifact/out/Dockerfile
GITHUB PR #332
JIRA Issue TEZ-4537
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 689c3cf8ac1b 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 5a2df54
Default Java Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-332/2/testReport/
Max. process+thread count 2090 (vs. ulimit of 5500)
modules C: tez-common tez-runtime-internals tez-runtime-library tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-332/2/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog
Copy link
Contributor

@ayushtkn : can you please rebase this patch on top of master? LGTM, let's just have a fresh test run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants