-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Excel file export #9924
feat: Excel file export #9924
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9924 +/- ##
==========================================
- Coverage 71.22% 69.77% -1.46%
==========================================
Files 585 184 -401
Lines 30828 18257 -12571
Branches 3237 0 -3237
==========================================
- Hits 21957 12738 -9219
+ Misses 8762 5519 -3243
+ Partials 109 0 -109
Continue to review full report at Codecov.
|
438ab2e
to
a116941
Compare
17c08eb
to
a116941
Compare
0765eba
to
92e89ce
Compare
just a general comment - it would be nice to fix CI first. |
@blcksrx - could you share more about this feature use case and why .csv is not good enough? e.g. excel supports csv files as well as I know |
Pulling over a comment from a Slack discussion: I would say it's worth embracing the growth of additional save/export options with a dropdown menu, e.g.:
... to avoid button proliferation and add a spot for future integrations. |
d096dcb
to
a116941
Compare
a116941
to
f061166
Compare
6519d3b
to
a116941
Compare
d5ed4b4
to
6ef5383
Compare
6ef5383
to
820319d
Compare
820319d
to
9ae1a9e
Compare
6b7de42
to
79aef2d
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
Hello @bkyryliuk. I have provided additional context on why this may be useful Not every user may be CSV-friendly users. Excel Export are easier to handle for those users. For me, this is about Superset being more accessible to generic users. This feature would be really helpful in production |
One additional use-case for Excel over CSV is that datetime formats are not preserved in CSV. If the data being exported contains several datetime columns, then since CSV does not store date formatting this data is lost. |
I would like to know why finally this is not included into Superset. Here you can read a very good explanation of the importance of this feature for end users. |
Actually Im frustrated about this, I made PRs two time about it, but after a while nobody did pay attention |
export-data-to-excel |
we need exporting as excel. it's common. |
1 similar comment
we need exporting as excel. it's common. |
++ |
SUMMARY
Support excel for exporting
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION