chore(deps-dev): bump eslint from 8.57.1 to 10.4.1 in /superset-frontend#40846
chore(deps-dev): bump eslint from 8.57.1 to 10.4.1 in /superset-frontend#40846dependabot[bot] wants to merge 3 commits into
Conversation
|
Bito Automatic Review Skipped - Files Excluded |
dosubot
Bot
added
the
javascript
rusackas
force-pushed
the
dependabot/npm_and_yarn/superset-frontend/eslint-10.4.1
branch
from
3414172 to
e1c746c
Compare
|
Picked this one up and pushed a migration commit ( What the v8→v10 bump actually requires hereThe frontend's primary linter is oxlint now — ESLint only survives in one spot: ESLint 9/10 breaking changes that bit us:
What I changed
Verification (local)
Remaining / notes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40846 +/- ##
==========================================
- Coverage 64.18% 64.18% -0.01%
==========================================
Files 2655 2655
Lines 143925 143925
Branches 33181 33181
==========================================
- Hits 92382 92380 -2
- Misses 49921 49923 +2
Partials 1622 1622
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Code Review Agent Run #6ddf91Actionable Suggestions - 0Additional Suggestions - 4
Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
rusackas
force-pushed
the
dependabot/npm_and_yarn/superset-frontend/eslint-10.4.1
branch
from
326dd1e to
abc6499
Compare
Code Review Agent Run #cb7898Actionable Suggestions - 0Additional Suggestions - 1
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
rusackas
force-pushed
the
dependabot/npm_and_yarn/superset-frontend/eslint-10.4.1
branch
from
abc6499 to
e90d8f1
Compare
Code Review Agent Run #b8c05dActionable Suggestions - 0Additional Suggestions - 1
Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.4.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.1...v10.4.1) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.4.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…mps) ESLint 8.57 -> 10.4 is a major bump that removes eslintrc support, the --no-eslintrc flag, and changes the rule/RuleTester APIs. The frontend's primary linter is oxlint; ESLint only runs the custom Superset rules + Prettier via scripts/oxlint-metrics-uploader.js (npm run lint-stats). Changes: - Migrate the active minimal config from .eslintrc.minimal.js (eslintrc) to eslint.config.minimal.js (flat config). Swap @babel/eslint-parser (no ESLint v10 support, scopeManager.addGlobals crash) for @typescript-eslint/parser; the custom rules are pure AST visitors. - Update the uploader command: drop removed --no-eslintrc, point --config at the flat config. - Remove dead eslintrc-format files (.eslintrc.js, .eslintrc.minimal.js, .eslintignore) — unsupported by v10 and no longer referenced; oxlint replaced the full ESLint rule set. - Port custom-rule RuleTester tests to flat-config API (parserOptions -> languageOptions; drop unsupported `type` error matcher). - Bump plugins to ESLint v10-compatible versions: @typescript-eslint/* 8.61, eslint-config-prettier 10, eslint-plugin-lodash 8, eslint-plugin-react-you-might-not-need-an-effect 1. Add overrides to satisfy ESLint v10 peers for laggards still capped at v9 (@babel/eslint-parser, eslint-plugin-import, eslint-plugin-jest-dom). Verified: strict `npm install` resolves to a single deduped eslint@10.4.1; the flat config lints all 1808 src files cleanly (only pre-existing findings); both custom-rule tests pass; oxlint and the lockfile are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The ESLint v10 migration removed .eslintignore, which oxlint relied on to ignore nested node_modules (and built lib/esm/dist, *.d.ts, storybook-static). oxlint.json only ignored top-level node_modules/**, so lint-frontend began scanning packages/*/node_modules and plugins/*/node_modules, producing tens of thousands of spurious errors. Make oxlint's ignorePatterns self-sufficient with glob-prefixed patterns so they match at any depth, independent of the deleted .eslintignore. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rusackas
force-pushed
the
dependabot/npm_and_yarn/superset-frontend/eslint-10.4.1
branch
from
e90d8f1 to
b58cb2f
Compare
Code Review Agent Run #4f4ebdActionable Suggestions - 0Filtered by Review RulesBito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Bumps eslint from 8.57.1 to 10.4.1.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
4a3d15a10.4.143e7e2bBuild: changelog update for 10.4.1e557467fix: update@eslint/plugin-kitversion to 0.7.2 (#20930)b0e466btest: adddataproperty to invalid tests cases for rules (#20924)d4ce898fix: propagate failures from delegated commands (#20917)f4f3507fix: prefer-arrow-callback invalid autofix with newline afterasync(#20916)f78838btest: add CodePath type coverage (#20904)61b0adddocs: remove deprecated rule from related rules ofmax-params(#20921)1daa4bdchore: updateeslint-plugin-eslint-commentstest data to latest commit (#20...002942cci: declare contents:read on update-readme workflow (#20919)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)