feat(mcp): change save_chart default to False for preview-first workflow #36935
Conversation
Change the default behavior of the MCP generate_chart tool to create preview-only charts by default (save_chart=False), requiring explicit save_chart=True to permanently save charts in Superset. This enables a safer, more iterative workflow where LLM agents can preview charts before deciding to save them, reducing clutter from temporary or experimental visualizations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Code Review Agent Run #a4ea08Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
|
CodeAnt AI finished reviewing your PR. |
💡 Enhance Your PR ReviewsWe noticed that 3 feature(s) are not configured for this repository. Enabling these features can help improve your code quality and workflow: 🚦 Quality GatesStatus: Quality Gates are not enabled at the organization level 🎫 Jira Ticket ComplianceStatus: Jira credentials file not found. Please configure Jira integration in your settings ⚙️ Custom RulesStatus: No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository Want to enable these features? Contact your organization admin or check our documentation for setup instructions. |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36935 +/- ##
===========================================
+ Coverage 0 68.17% +68.17%
===========================================
Files 0 639 +639
Lines 0 47657 +47657
Branches 0 5204 +5204
===========================================
+ Hits 0 32491 +32491
- Misses 0 13886 +13886
- Partials 0 1280 +1280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Address review feedback by adding a validator that ensures at least one of save_chart or generate_preview is True. This prevents no-op requests where both flags are False. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Code Review Agent Run #1bcb43Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
sadpandajoe
added
the
review:checkpoint
2 participants
SUMMARY
Change the default behavior of the MCP
generate_charttool to create preview-only charts by default (save_chart=False), requiring explicitsave_chart=Trueto permanently save charts in Superset.This enables a safer, more iterative workflow where LLM agents can preview charts before deciding to save them, reducing clutter from temporary or experimental visualizations.
Changes:
save_chartdefault fromTruetoFalseinGenerateChartRequestschemagenerate_chart.pyto reflect the new default behaviorBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - This is a behavioral default change with no UI changes.
TESTING INSTRUCTIONS
generate_charttool without specifyingsave_chartsave_chart=Trueand verify the chart IS savedpytest tests/unit_tests/mcp_service/ -vADDITIONAL INFORMATION
🤖 Generated with Claude Code