Skip to content

fix(sqllab): add colorEditorSelection token for visible text selection #36932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadpandajoe merged 1 commit into from
Jan 22, 2026
+16 −1
Merged

fix(sqllab): add colorEditorSelection token for visible text selection #36932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions superset-frontend/packages/superset-core/src/ui/theme/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,13 @@ export interface SupersetSpecificTokens {
echartsOptionsOverridesByChartType?: {
[chartType: string]: any;
};

// Editor-related
/**
* Background color for code editor text selection.
* Defaults to colorPrimaryBgHover if not specified.
*/
colorEditorSelection?: string;
}

/**
Expand Down
3 changes: 2 additions & 1 deletion superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,8 @@ export function AsyncAceEditor(
}
/* Adjust selection color */
.ace_editor .ace_selection {
background-color: ${token.colorPrimaryBgHover} !important;
background-color: ${token.colorEditorSelection ??
token.colorPrimaryBgHover} !important;
}

/* Improve active line highlighting */
Expand Down
7 changes: 7 additions & 0 deletions superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,8 @@ class D3TimeFormat(TypedDict, total=False):
"fontWeightNormal": "400",
"fontWeightLight": "300",
"fontWeightStrong": "500",
# Editor selection color (for SQL Lab text highlighting)
"colorEditorSelection": "#fff5cf",
},
"algorithm": "default",
}
Expand All @@ -813,6 +815,11 @@ class D3TimeFormat(TypedDict, total=False):
# Set to None to disable dark mode
THEME_DARK: Optional[Theme] = {
**THEME_DEFAULT,
"token": {
**THEME_DEFAULT["token"],
# Darker selection color for dark mode
"colorEditorSelection": "#5c4d1a",
},
"algorithm": "dark",
}

Expand Down
Loading