Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker refactor #31385

Merged
merged 42 commits into from
Dec 14, 2024
Merged

fix: docker refactor #31385

merged 42 commits into from
Dec 14, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Dec 10, 2024 •
edited
Loading

Fixes #31357 and #31360

Also other docker-related improvements:

  • fixes ephemeral envs
  • perms: superset user has now less access in-docker, can basically run the few scripts is needs as entrypoints and has readonly access to the app itself. This is good as if the app is compromised, the attacker can't change the app itself to exploit further security issues
  • uses uv and its venv now
  • simplify the headless browser section, should make image smaller if no browser are installed
  • python app gets "compiled" with pyc files created upfront for a faster startup time
  • refactor how translations are compiled, using isolated stages for backend/frontend now

@mistercrunch mistercrunch mentioned this pull request Dec 10, 2024
Closed
9 tasks
@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://54.149.181.65:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch mistercrunch mentioned this pull request Dec 10, 2024
Closed
This was referenced Dec 10, 2024
Closed
Closed
@mistercrunch mistercrunch marked this pull request as ready for review December 10, 2024 22:41
@dosubot dosubot bot added the install:docker Installation - docker container label Dec 10, 2024
@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment creation failed. Please check the Actions logs for details.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment creation failed. Please check the Actions logs for details.

eschutho
eschutho reviewed Dec 11, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://34.209.140.91:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment creation failed. Please check the Actions logs for details.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment creation failed. Please check the Actions logs for details.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment creation failed. Please check the Actions logs for details.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://34.220.183.190:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@mistercrunch
Copy link
Member Author

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Processing your ephemeral environment request here.

@github-actions GitHub Actions
Copy link
Contributor

@mistercrunch Ephemeral environment spinning up at http://34.220.183.190:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho self-requested a review December 14, 2024 00:09
eschutho
eschutho reviewed Dec 14, 2024
View reviewed changes
docker/.env
@@ -17,6 +17,7 @@


COMPOSE_PROJECT_NAME=superset
DEV_MODE=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything that needs to be done for official docker images built during releases to remove this flag?

@mistercrunch mistercrunch merged commit 1f17b97 into master Dec 14, 2024
33 checks passed
@mistercrunch mistercrunch deleted the simplify_docker branch December 14, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar left review comments

@eschutho eschutho eschutho approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code install:docker Installation - docker container preset-io size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'superset'
3 participants
@mistercrunch @dpgaspar @eschutho