refactor: Split SliceHeaderControls into smaller files #31270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -310,13 +309,13 @@ test('Should show "Drill to detail" with `can_explore` & `can_samples` perms', ( | |||
| (global as any).featureFlags = { | |||
| [FeatureFlag.DrillToDetail]: true, | |||
| }; | |||
| const props = { | |||
| ...createProps(), | |||
| supersetCanExplore: true, | |||
There was a problem hiding this comment.
Removing this (supersetCanExplore: true) because of the hook usage now?
There was a problem hiding this comment.
Yes, wasn’t necessary in this test
Antonio-RiveroMartnez
approved these changes
Dec 3, 2024
michael-s-molina
added
the
review:checkpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Small refactor to make SliceHeaderControls file easier to read and maintain. Move some functions and types to separate files, move a subcomponent to a separate file, use
usePermissionshook to get permissions.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
No functional changes, if the tests pass we should be good to go
ADDITIONAL INFORMATION