chore: remove flaky test #30395
Closed
chore: remove flaky test #30395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
force-pushed
the
elizabeth/remove-flaky-tests
branch
from
60dbd6f
to
474ee79
Compare
eschutho
force-pushed
the
elizabeth/remove-flaky-tests
branch
2 times, most recently
from
329dbce
to
8cbc62f
Compare
eschutho
force-pushed
the
elizabeth/remove-flaky-tests
branch
from
8cbc62f
to
adf2d9c
Compare
eschutho
force-pushed
the
elizabeth/remove-flaky-tests
branch
from
adf2d9c
to
28e6f8f
Compare
eschutho
force-pushed
the
elizabeth/remove-flaky-tests
branch
from
c9d0311
to
05cc216
Compare
eschutho
force-pushed
the
elizabeth/remove-flaky-tests
branch
from
05cc216
to
0eda181
Compare
sadpandajoe
reviewed
Sep 26, 2024
| @@ -312,15 +312,15 @@ describe('Native filters', () => { | |||
| }); | |||
|
|
|||
| describe('Nativefilters initial state not required', () => { | |||
There was a problem hiding this comment.
instead of skipping each test, i believe if you did a describe.skip() you'll skip all tests in the describe block
sadpandajoe
reviewed
Sep 26, 2024
| @@ -81,7 +81,7 @@ describe('Horizontal FilterBar', () => { | |||
| setFilterBarOrientation('vertical'); | |||
| }); | |||
|
|
|||
| it('should show all default actions in horizontal mode', () => { | |||
| it.skip('should show all default actions in horizontal mode', () => { | |||
There was a problem hiding this comment.
instead of doing all the skips here and below, you can just do it.only and it'll only run that test above. You can probably put a note after that test to list out why you're skipping all these other tests
sadpandajoe
reviewed
Sep 26, 2024
| ); | ||
| }); | ||
| }); | ||
| // describe('No Results', () => { |
There was a problem hiding this comment.
you can do a describe.skip here to skip all these tests
|
one thing, if we're skipping tests, we should probably add a comment in the file to see why we are skipping all these tests. |
github-actions
bot
added
the
github_actions
eschutho
force-pushed
the
elizabeth/remove-flaky-tests
branch
from
a86c0f1
to
0affb6f
Compare
eschutho
force-pushed
the
elizabeth/remove-flaky-tests
branch
2 times, most recently
from
faf3ab4
to
0eda181
Compare
github-actions
bot
removed
the
github_actions
github-actions
bot
added
the
github_actions
| -v "$GITHUB_WORKSPACE/superset-frontend/cypress-base:/e2e" \ | ||
| -w /e2e \ | ||
| cypress/browsers:node-20.16.0-chrome-127.0.6533.119-1 \ | ||
| npx cypress run --browser chrome $USE_DASHBOARD_FLAG |
There was a problem hiding this comment.
I think that mean means no parallelism, guessing you're not meaning to merge this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Continuing to debug the flaky cypress issues.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION