fix: JSON loading logs

[michael-s-molina]

SUMMARY

#28702 unified JSON calls to a single module which is great. Unfortunately, that PR also altered the default behavior when loading a JSON object and added a log entry every time an invalid object is parsed to the utility function. It is the responsibility of the caller to decide how to deal with an invalid JSON. In many places, a default empty object is used when an invalid JSON is received and there's no need for extra logs. This PR restores the previous behavior.

Fixes #30079

TESTING INSTRUCTIONS

Check the original issue for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (76d897e) to head (b7a55f2).
Report is 658 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #30138       +/-   ##
===========================================
+ Coverage   60.48%   83.65%   +23.16%     
===========================================
  Files        1931      529     -1402     
  Lines       76236    38268    -37968     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32013    -14101     
+ Misses      28017     6255    -21762     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.90% <16.66%> (-0.26%)	⬇️
javascript	?
mysql	76.73% <100.00%> (?)
postgres	76.81% <100.00%> (?)
presto	53.48% <16.66%> (-0.32%)	⬇️
python	83.65% <100.00%> (+20.16%)	⬆️
sqlite	76.27% <100.00%> (?)
unit	60.25% <100.00%> (+2.63%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mistercrunch]

LGTM - my bad for letting that previous one slip allow for a change in behavior. I'm really glad we've centralize all that json-related logic here though!

[eyalezer]

@michael-s-molina - good catch, thanks
@mistercrunch - indeed , at least now we got it all in one place ☺️