-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: HTML embedding of charts/dashboards without authentication #30032
Conversation
using Flask-OIDC
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Answering the question of @kormpakis made me aware that I forgot to include this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice addition, something that has been sorely missing from the documentation - thank you!! Let me know if you have questions or disagree with any of my suggestions.
Co-authored-by: Sam Firke <[email protected]>
Thanks @lindner-tj ! Sorry for the slow re-review. |
@sfirke no worries, thank you for merging :) |
SUMMARY
Was trying to figure out how to embed dashboards/charts in other websites without SDK, came across this: #28407 I got it working and thought it would be a great addition to the docs.
PR is specifically for docs/docs/configuration/networking-settings.mdx
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Add frame ancestors to Flask Talisman CSP, restart Superset and embed whatever public dashboard/chart you like
ADDITIONAL INFORMATION