Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reports are not sent when selecting to send as PNG, CSV or text #30001

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: Reports are not sent when selecting to send as PNG, CSV or text #30001

merged 1 commit into from
Aug 23, 2024

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Aug 23, 2024 •
edited by sadpandajoe
Loading

In AlertReportModal.tsx, it looks like extra cannot be null which is causing 500s when trying to send a report as PNG, CSV or text.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho
Update AlertReportModal.tsx
454770b 
Extra cannot be null
@dosubot dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Aug 23, 2024
@sadpandajoe sadpandajoe changed the title Update AlertReportModal.tsx fix: Reports are not sent when selecting to send as PNG, CSV or text Aug 23, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 23, 2024
@rusackas rusackas merged commit 9249fac into master Aug 23, 2024
39 of 42 checks passed
@rusackas rusackas deleted the eschutho-patch-1 branch August 23, 2024 16:56
@sadpandajoe sadpandajoe removed the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 23, 2024
@sadpandajoe
Copy link
Member

breaking code isn't currently in 4.1 so removing the label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature preset-io size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eschutho @sadpandajoe @rusackas