chore(docs): adds QuestDB to databases config page #29800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rusackas
reviewed
Jul 31, 2024
rusackas
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Caught a typo, but otherwise this looks great to me! Thank you! Feel free to add the logo to the website/docs, too, if you'd like.
@betodealmeida may also be able to help make sure QuestDB is covered here on the compatibility matrix:
https://github.com/apache/superset/tree/master/superset/db_engine_specs
|
@rusackas Yes! Thank you. Heh, vacation next week. Goo-brain for sure. Added the logo, appreciate the invitation. Happy to help with matrix if I can? |
|
Oh we also have this db engine spec PR for QuestDB. Not sure if someone can take this across the finish line. |
|
Miguel, the author of that PR, is no longer with QuestDB unfortunately. It may require Superset-side assistance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds QuestDB to the database pages. We offer similar guidance in our documentation.
https://superset.apache.org/docs/configuration/databases
https://questdb.io/docs/third-party-tools/superset/