Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix query typo in creating-your-first-dashboard.mdx #29631

Merged
merged 1 commit into from
Jul 22, 2024
Merged

docs: fix query typo in creating-your-first-dashboard.mdx #29631

merged 1 commit into from
Jul 22, 2024

Conversation

Jaswanth-Sriram-Veturi
Copy link
Contributor

SUMMARY

The existing sql expression example in superset semantic layer section is not valid.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Jul 18, 2024
github-actions[bot]
github-actions bot reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

sfirke
sfirke approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sfirke sfirke merged commit 2a9a1d3 into apache:master Jul 22, 2024
35 checks passed
@sfirke sfirke changed the title docs: update creating-your-first-dashboard.mdx docs: fix query typo in creating-your-first-dashboard.mdx Jul 22, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@Jaswanth-Sriram-Veturi @eschutho
docs: update creating-your-first-dashboard.mdx (#29631)
2021f10
@sadpandajoe
Copy link
Member

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
sadpandajoe pushed a commit that referenced this pull request Aug 13, 2024
@Jaswanth-Sriram-Veturi @sadpandajoe
docs: update creating-your-first-dashboard.mdx (#29631)
30fbfa1 
(cherry picked from commit 2a9a1d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@sfirke sfirke sfirke approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
doc Namespace | Anything related to documentation size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jaswanth-Sriram-Veturi @sadpandajoe @sfirke @michael-s-molina