fix(dataset): Obscure error message on creation #29554
Open
+50
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following up #25669 and #24969
This commit adds the SupersetSecurityException case that displays the error message from the statement validation error.
(When a SupersetSecurityException error is thrown while creating a dataset, it only shows "Fater Error" error message.)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Go to SQL Lab and create an invalid select statement (
(SELECT 1)
with parentheses)Create a dataset and see the error message
ADDITIONAL INFORMATION