-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup documentation #29552
chore: cleanup documentation #29552
Conversation
- Fenced code blocks should have a language specified - Fenced code blocks should be surrounded by blank lines - Reversed link syntax - Headings should be surrounded by blank lines - Multiple consecutive blank lines - Heading levels should only increment by one level at a time
This is a step by step document, and in the last step, user will change directory to `superset-frontend/`. Users need to know where they should run the compile command.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29552 +/- ##
===========================================
+ Coverage 60.48% 83.65% +23.16%
===========================================
Files 1931 524 -1407
Lines 76236 37732 -38504
Branches 8568 0 -8568
===========================================
- Hits 46114 31565 -14549
+ Misses 28017 6167 -21850
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can someone run the tests again? I just changed some md files. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I re-ran the failing test. This can be merged when passing CI. |
This will fix the Markdown warnings and comment on where pybabel compile should be run.