Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup documentation #29552

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

CodeWithEmad
Copy link
Contributor

This will fix the Markdown warnings and comment on where pybabel compile should be run.

- Fenced code blocks should have a language specified
- Fenced code blocks should be surrounded by blank lines
- Reversed link syntax
- Headings should be surrounded by blank lines
- Multiple consecutive blank lines
- Heading levels should only increment by one level at a time
This is a step by step document, and in the last step, user will change directory to `superset-frontend/`. Users need to know where they should run the compile command.
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (76d897e) to head (63651ff).
Report is 442 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29552       +/-   ##
===========================================
+ Coverage   60.48%   83.65%   +23.16%     
===========================================
  Files        1931      524     -1407     
  Lines       76236    37732    -38504     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31565    -14549     
+ Misses      28017     6167    -21850     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.11% <ø> (-0.05%) ⬇️
javascript ?
mysql 77.00% <ø> (?)
postgres 77.09% <ø> (?)
presto 53.70% <ø> (-0.10%) ⬇️
python 83.65% <ø> (+20.16%) ⬆️
sqlite 76.57% <ø> (?)
unit 59.68% <ø> (+2.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodeWithEmad
Copy link
Contributor Author

Can someone run the tests again? I just changed some md files. :)

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfirke
Copy link
Member

sfirke commented Jul 11, 2024

I re-ran the failing test. This can be merged when passing CI.

@sfirke sfirke added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Jul 11, 2024
@mistercrunch mistercrunch merged commit 84a1cd2 into apache:master Jul 11, 2024
41 of 42 checks passed
@CodeWithEmad CodeWithEmad deleted the chore/cleanup branch July 11, 2024 21:56
eschutho pushed a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation merge-if-green If approved and tests are green, please go ahead and merge it for me size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants