fix: babel_update script crash #29548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds the Jinja2 package to the translation requirements. When following the instructions mentioned in [Superset's contributing documentation](https://superset.apache.org/docs/contributing/howtos/#creating-a-new-language-dictionary) and running the `babel_update.sh` script, it currently fails due to a missing extraction method, which requires Jinja2.
dosubot
bot
added
global:jinja
3 tasks
github-actions
bot
added
i18n
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29548 +/- ##
===========================================
+ Coverage 60.48% 83.65% +23.16%
===========================================
Files 1931 524 -1407
Lines 76236 37732 -38504
Branches 8568 0 -8568
===========================================
- Hits 46114 31565 -14549
+ Misses 28017 6167 -21850
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rusackas
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the Jinja2 package to the translation requirements. When following the instructions mentioned in Superset's contributing documentation and running the
babel_update.shscript, it currently fails due to a missing extraction method, which requires Jinja2.