Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unsupported Slack API calls #29532

Closed

Conversation

PuszekSE
Copy link

@PuszekSE PuszekSE commented Jul 9, 2024

SUMMARY

Issue/29480 invalid slack operation

I've used very naive approach of simply replacing method calls for 'files_upload', since the method using it has already been marked for deprecation inside Superset.

TESTING INSTRUCTIONS

Setup Slack Token API-based notification using dashboard.
Actually send the notification, instead of receiving API deprecation response from Slack.

ADDITIONAL INFORMATION

  • Has associated issue: fixes Slack Notification - deprecated API  #29480
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas rusackas requested a review from eschutho July 10, 2024 16:07
@rusackas
Copy link
Member

Thanks for the PR! I think @eschutho is working on the same thing... hopefully we're not duplicating efforts. I've added her as a reviewer.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.68%. Comparing base (76d897e) to head (cff96ac).
Report is 436 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29532       +/-   ##
===========================================
+ Coverage   60.48%   83.68%   +23.19%     
===========================================
  Files        1931      523     -1408     
  Lines       76236    37633    -38603     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31492    -14622     
+ Misses      28017     6141    -21876     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.10% <0.00%> (-0.06%) ⬇️
javascript ?
postgres 77.14% <100.00%> (?)
presto 53.70% <0.00%> (-0.10%) ⬇️
python 83.68% <100.00%> (+20.19%) ⬆️
sqlite 76.62% <100.00%> (?)
unit 59.67% <0.00%> (+2.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eschutho
Copy link
Member

Hi, thanks @PuszekSE for the contribution! As @rusackas mentioned, I had a similar PR here but it turns out that the v2 api has a different schema, so I'm implementing another larger change based on the new flow here. I'll close this PR and you can track (and comment) on the current one.

@eschutho eschutho closed this Jul 10, 2024
@PuszekSE PuszekSE deleted the issue/29480_invalid-slack-operation branch July 10, 2024 23:51
@PuszekSE
Copy link
Author

Thank you for the feedback!

@rusackas
Copy link
Member

Thank you for the feedback!

Thank you for the PR! We appreciate this, and any other contribution you're willing to make to the project. Feel free to reach out on slack if you ever want to discuss other opportunities to do so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants