fix: Table time comparison breaking after form data update #29525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -203,4 +203,60 @@ describe('ControlPanelsContainer', () => { | |||
| 'percent_metrics', | |||
| ); | |||
| }); | |||
|
|
|||
| test('hidden state of controls is correctly applied', async () => { | |||
michael-s-molina
added
the
review:checkpoint
rusackas
removed
the
review:checkpoint
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
PR #28312 introduced an issue in time comparison feature in Table viz plugin.
This PR swaps
visibilitytohiddenin time comparison controls, so that their values would not get removed from form data.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2024-07-09.at.11.52.53.mov
After:
Screen.Recording.2024-07-09.at.11.51.19.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION