Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins): Big Number with Time Comparison #29520

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

Use correct name to access dashboard filter in Big Number with Time Comparison plugin so the values are not combined but properly separated into bigNumber and the comparison one.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BN combining both values into one error:
Screenshot 2024-07-09 at 1 25 52 AM

Fix
Screenshot 2024-07-09 at 1 26 07 AM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Use correct name to access dashbpard filter in Big Number with Time Comparison plugin
@dosubot dosubot bot added the viz:charts:bignumber Related to BigNumber charts label Jul 8, 2024
Copy link
Member

@sadpandajoe sadpandajoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yousoph yousoph merged commit b481bc9 into apache:master Jul 8, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants