-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Download to CSV shows a special Chinese characters #29506
Conversation
(FIX) Download to CSV shows a special Chinese character apache#29410
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29506 +/- ##
===========================================
+ Coverage 60.48% 83.69% +23.20%
===========================================
Files 1931 521 -1410
Lines 76236 37488 -38748
Branches 8568 0 -8568
===========================================
- Hits 46114 31376 -14738
+ Misses 28017 6112 -21905
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Let's not downgrade every single installs because of a particular issue that's important to a few, as it's fair to assume that many others may need the progress that exists since that version was published. Is there a werkzeug-specific documented issue for this? I'd much rather push forward rather then stepping back. If we think this is important enough to prevent certain version, the proper way to do it would be to change the range in pyproject.toml and add a comment right above where we set the range explaining why the upper bound is in effect, ideally linking to a werkzeug-hosted issue. |
I agree with you; I think it's related to non-English characters. I've opened a bug issue case with Werkzeug to check on this: pallets/werkzeug#2922. This bug appeared starting from |
Closing for now, happy to push Werkzeug dependency forward when the fix is in |
fix: Download to CSV shows a special Chinese characters.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION