Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): Add OceanBase support #29496

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

yuanoOo
Copy link
Contributor

@yuanoOo yuanoOo commented Jul 5, 2024

SUMMARY

OceanBase is an enterprise-level open source distributed relational database with high availability, high performance, horizontal scalability, and compatibility with SQL standards.
Although OceanBase is compatible with the MySQL protocol, there are still some differences in data types, SQL syntax, etc.

https://en.oceanbase.com/docs/common-oceanbase-database-10000000001375342
https://en.oceanbase.com/docs/common-oceanbase-database-10000000001375338

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • after
    20240705102847

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Jul 5, 2024
@dosubot dosubot bot added the data:connect Namespace | Anything related to db connections / integrations label Jul 5, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@yuanoOo
Copy link
Contributor Author

yuanoOo commented Jul 5, 2024

@john-bodley Can you take a look in your free time.

@zhaoyongjie
Copy link
Member

@yuanoOo please adding license header in new files, ping me please if you need helping. Thanks for your contributions!

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.57%. Comparing base (76d897e) to head (2c8fe4b).
Report is 424 commits behind head on master.

Files Patch % Lines
superset/db_engine_specs/oceanbase.py 95.12% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29496       +/-   ##
===========================================
+ Coverage   60.48%   70.57%   +10.08%     
===========================================
  Files        1931     1968       +37     
  Lines       76236    79255     +3019     
  Branches     8568     8972      +404     
===========================================
+ Hits        46114    55934     +9820     
+ Misses      28017    21123     -6894     
- Partials     2105     2198       +93     
Flag Coverage Δ
hive 49.27% <95.12%> (+0.10%) ⬆️
javascript 58.05% <ø> (+0.33%) ⬆️
mysql 77.05% <95.12%> (?)
postgres 77.42% <95.12%> (?)
presto 54.06% <95.12%> (+0.26%) ⬆️
python 83.89% <95.12%> (+20.41%) ⬆️
sqlite 76.92% <95.12%> (?)
unit 59.90% <95.12%> (+2.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuanoOo
Copy link
Contributor Author

yuanoOo commented Jul 8, 2024

@yuanoOo please adding license header in new files, ping me please if you need helping. Thanks for your contributions!

@zhaoyongjie Thanks for the reminder, I've fixed it. Can you help trigger the github workflow again?

@rusackas rusackas requested a review from villebro July 8, 2024 17:17
@yuanoOo
Copy link
Contributor Author

yuanoOo commented Jul 9, 2024

@zhaoyongjie @rusackas Hi, After my review, the reason for the failure of GitHub Workflow does not seem to be related to this PR.
But I'm not sure, can you help me check it out? Thanks.

@zhaoyongjie zhaoyongjie closed this Jul 9, 2024
@zhaoyongjie zhaoyongjie reopened this Jul 9, 2024
@zhaoyongjie
Copy link
Member

@yuanoOo I've retriggered the CI.

@zhaoyongjie zhaoyongjie self-requested a review July 9, 2024 09:26
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit b4560d4 into apache:master Jul 9, 2024
73 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect Namespace | Anything related to db connections / integrations doc Namespace | Anything related to documentation size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants