chore: run babel_update.sh to update po files #29476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Periodically we need to run this script to rebuild the list of translatable strings from static analysis of the code base.
Also adding
--no-location
topybabel extract
fixing merge conflicts issues we've been having around these .po files.Also fixing the docs builds, they've been broken.
About the fact that merge conflicts are really tricky around translation work in general, I was thinking it may be doable to write a simple utility that would strip all comments from po files, as they are just comments referencing where the msgid exists, and operate at that level if/when needed. Like you hit a merge conflict, strip both files from comment, diff them, and commit without comments. I think the next pybabel script run would bring back the comments.~~Maybe we even want to pass a flag to pybabel to compeltely avoid adding source references as comments. We'd loose the ability to easily find where the string lives in the codebase, but for that you can just
git grep
. ~~