Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When Superset triggers OAuth2 it needs to pass to the OAuth provider a redirect URL, to where the user will be sent with the initial OAuth2 code after granting access to Superset. This redirect URL is built using
url_for
, and needs to run in a Flask request context in order to have access to the applicationSERVER_NAME
, in addition toPREFERRED_URL_SCHEME
andAPPLICATION_ROOT
.This PR modifies the
get_sql_results
Celery task to run the query under a dummy request context. This is enough for Superset to compute the redirect URL when the database is configured to run in async mode.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION