Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dashboard hangs when initial filters cannot be loaded #29456

Conversation

michael-s-molina
Copy link
Member

SUMMARY

The filter option "Select first filter value by default" is generally used when users want the dashboard to load with initial filters set. This is important when charts have a lot of data or they don't make sense without an initial filter. This PR fixes a bug were the dashboard could not leave the loading state when these initial filters could not be loaded. Now it will correctly display a message to the user informing which filters are failing and preventing the dashboard from rendering.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-07-02 at 11 36 29 Screenshot 2024-07-02 at 11 35 45

TESTING INSTRUCTIONS

1 - Create a filter with the "Select first filter value by default" option checked
2 - Simulate a failure when loading the filter
3 - Check that the dashboard presents a message indicating which filter is preventing the dashboard from rendering

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team July 2, 2024 14:51
@dosubot dosubot bot added dashboard:error Related to Dashboard errors dashboard:filtersets Related to the filtersets of the Dashboard labels Jul 2, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Jul 2, 2024
@michael-s-molina michael-s-molina merged commit 35da6ac into apache:master Jul 3, 2024
37 of 38 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jul 3, 2024
@rusackas rusackas removed the review:checkpoint Last PR reviewed during the daily review standup label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:error Related to Dashboard errors dashboard:filtersets Related to the filtersets of the Dashboard size/M v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants