Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show_filters URL parameter is not working #29422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hexcafe
Copy link
Contributor

@hexcafe hexcafe commented Jul 1, 2024

SUMMARY

Problem:
When embedding the dashboard, the filter panel does not hide even when show_filters is set to false.
After a quick investigation, I found that this parameter is not being handled at all.

Expected Behavior:

  • By default, the filter panel will be shown.
  • The filter panel should be hidden if the show_filters parameter is explicitly set to false or 0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added dashboard Namespace | Anything related to the Dashboard dashboard:native-filters Related to the native filters of the Dashboard labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:native-filters Related to the native filters of the Dashboard dashboard Namespace | Anything related to the Dashboard size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant