-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): uplift Storybook to v8 #29408
Conversation
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…book v8 Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I do see some broken and misbehaving stories, but as far as I can tell, they look like the same ones we got as a byproduct of bumping to Storybook 7. I don't see anything materially different. Hopefully we can fix some of these stories over time and make the world a better place. In the meantime, this looks like progress to me!
Just looks like it needs a new npm lock file to be mergeable.
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
The lockfile is synced now :D Hopefully no new pkg change incoming 😝 |
Yikes, looks like my attempt at reconcilating the lockfile didn't work. 1 moment please 🎶 |
Signed-off-by: hainenber <[email protected]>
PR is merge-able now :D |
I think this is good to move forward, but we'll need a code owner review (probably due to the Metadata Bar component) from @michael-s-molina @kgabryje or @geido to merge this. |
hi Superset folks, anything I can do to have this merged? |
Pinging those three folks again on Slack... hopefully we can get a code owner stamp soon. |
Signed-off-by: hainenber <[email protected]>
feat(build): uplift Storybook to v8
SUMMARY
Uplift Storybook used in
superset-frontend
to latest version as of now (v8). I rannpm run storybook build-storybook plugins:build-storybook plugins:storybook
and check most stories are OK except for a few stories seemingly to fail before the Storybook upliftlegacy-chart-plugins-legacy-preset-chart-nvd3-pie--basic
legacy-chart-plugins-legacy-plugin-chart-paired-t-test--basic
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
All stories executed by
npm run storybook
andnpm run plugins:storybook
must be successful.ADDITIONAL INFORMATION