Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): uplift Storybook to v8 #29408

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Jun 29, 2024

feat(build): uplift Storybook to v8

SUMMARY

Uplift Storybook used in superset-frontend to latest version as of now (v8). I ran npm run storybook build-storybook plugins:build-storybook plugins:storybook and check most stories are OK except for a few stories seemingly to fail before the Storybook uplift

  • legacy-chart-plugins-legacy-preset-chart-nvd3-pie--basic
image
  • legacy-chart-plugins-legacy-plugin-chart-paired-t-test--basic
image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

All stories executed by npm run storybook and npm run plugins:storybook must be successful.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber hainenber changed the title feat(build): Uplift Storybook to v8 feat(build): uplift Storybook to v8 Jun 30, 2024
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I do see some broken and misbehaving stories, but as far as I can tell, they look like the same ones we got as a byproduct of bumping to Storybook 7. I don't see anything materially different. Hopefully we can fix some of these stories over time and make the world a better place. In the meantime, this looks like progress to me!

Just looks like it needs a new npm lock file to be mergeable.

@hainenber
Copy link
Contributor Author

The lockfile is synced now :D

Hopefully no new pkg change incoming 😝

@hainenber
Copy link
Contributor Author

Yikes, looks like my attempt at reconcilating the lockfile didn't work. 1 moment please 🎶

@hainenber
Copy link
Contributor Author

PR is merge-able now :D

@rusackas
Copy link
Member

rusackas commented Jul 2, 2024

I think this is good to move forward, but we'll need a code owner review (probably due to the Metadata Bar component) from @michael-s-molina @kgabryje or @geido to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants