Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Cleanup Celery tests #29355

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jun 25, 2024

SUMMARY

Whilst spelunking through the tests, I realized that the Celery tests only require the data which backs the "Birth Names Dashboard" as opposed to the actual dashboard and associated charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (76d897e) to head (58ee216).
Report is 357 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29355       +/-   ##
===========================================
+ Coverage   60.48%   83.75%   +23.26%     
===========================================
  Files        1931      518     -1413     
  Lines       76236    37623    -38613     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31510    -14604     
+ Misses      28017     6113    -21904     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.90% <ø> (-0.26%) ⬇️
javascript ?
mysql 77.29% <ø> (?)
postgres 77.40% <ø> (?)
presto 53.51% <ø> (-0.30%) ⬇️
python 83.75% <ø> (+20.26%) ⬆️
sqlite 76.85% <ø> (?)
unit 59.20% <ø> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley merged commit c12b4e9 into apache:master Jun 25, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants