Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Ensure fixture is invoked #29352

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

During testing I realized that the example data wasn't being loaded when testing the SQL Lab functionality. Per the documentation it seems like fixtures are only invoked at the class or test function level and not for utility methods.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review June 24, 2024 21:17
@dosubot dosubot bot added the sqllab Namespace | Anything related to the SQL Lab label Jun 24, 2024
@john-bodley john-bodley merged commit d69363e into master Jun 25, 2024
59 of 60 checks passed
@john-bodley john-bodley deleted the john-bodley--fix-fixture branch June 25, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants