Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cannot delete empty column inside a tab using the dashboard editor #29346

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix: Cannot delete empty column inside a tab using the dashboard editor #29346

merged 1 commit into from
Jun 24, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a z-index problem that prevented an user from deleting an empty column inside a tab using the dashboard editor.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-06-24 at 11 38 31 Screenshot 2024-06-24 at 11 38 07

TESTING INSTRUCTIONS

Check that you can delete an empty column inside a tab.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend dashboard:editmode Related to te Dashboard edit mode labels Jun 24, 2024
@rusackas rusackas merged commit ee52277 into apache:master Jun 24, 2024
36 of 37 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 25, 2024
michael-s-molina added a commit that referenced this pull request Jun 26, 2024
@michael-s-molina
fix: Cannot delete empty column inside a tab using the dashboard edit…
35f3a49 
…or (#29346)

(cherry picked from commit ee52277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@justinpark justinpark Awaiting requested review from justinpark

@kgabryje kgabryje Awaiting requested review from kgabryje

@sfirke sfirke Awaiting requested review from sfirke

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend dashboard:editmode Related to te Dashboard edit mode size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michael-s-molina @rusackas