Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert/reports): adding logic to handle downstream reports when tab is deleted from dashboard #29333

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented Jun 22, 2024

SUMMARY

Adding logic to handle the deletion of tabs when a report or alert is related to that dashboard. Upon deletion, if there is a related report or alert, that report will be set as inactive, and an email will be generated and sent to the report owner.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Create a dashboard with a tab in it.
Create a new alert of report with the tab selected under the content section.
Save the report.
Go back to the dashboard, remove the tab, and save.
Return to the newly created report. Status should be inactive
Check the email of the owner. It should have received an email notifying the owner of the change.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: [ALERT_REPORTS=True, ALERT_REPORT_TABS=True]
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@fisjac fisjac marked this pull request as draft June 22, 2024 01:19
@github-actions github-actions bot added the api Related to the REST API label Jun 22, 2024
@dosubot dosubot bot added the dashboard:tab Related to the usage of tabs in the Dashboard label Jun 22, 2024
@fisjac fisjac changed the title Ar tabs/tab deletion feat(alert/reports): adding logic to handle downstream reports when tab is deleted from dashboard Jun 22, 2024
@github-actions github-actions bot removed api Related to the REST API dependencies:npm labels Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.56%. Comparing base (76d897e) to head (7e4c272).
Report is 624 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29333       +/-   ##
===========================================
+ Coverage   60.48%   70.56%   +10.07%     
===========================================
  Files        1931     1973       +42     
  Lines       76236    79308     +3072     
  Branches     8568     9039      +471     
===========================================
+ Hits        46114    55962     +9848     
+ Misses      28017    21128     -6889     
- Partials     2105     2218      +113     
Flag Coverage Δ
hive 48.92% <21.05%> (-0.24%) ⬇️
javascript 58.39% <ø> (+0.68%) ⬆️
mysql 76.69% <100.00%> (?)
postgres 76.76% <100.00%> (?)
presto 53.47% <21.05%> (-0.34%) ⬇️
python 83.66% <100.00%> (+20.17%) ⬆️
sqlite 76.25% <100.00%> (?)
unit 60.27% <21.05%> (+2.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fisjac fisjac force-pushed the ar-tabs/tab-deletion branch 2 times, most recently from 19d0cf0 to c1d40b1 Compare August 20, 2024 18:01
@fisjac fisjac marked this pull request as ready for review August 20, 2024 18:28
@dosubot dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Aug 20, 2024
@fisjac fisjac merged commit 2fda221 into apache:master Aug 23, 2024
59 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature dashboard:tab Related to the usage of tabs in the Dashboard review:draft size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants